Allow owners to change their subnet symbol #1770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0r1s
added
the
skip-cargo-audit
…e TokenSymbol directly
l0r1s
requested review from
sam0x17,
shamil-gadelshin,
JohnReedV,
open-junius,
gztensor and
ales-otf
| ) -> DispatchResult { | ||
| Self::ensure_subnet_owner_or_root(origin, netuid)?; | ||
|
|
||
| if SYMBOLS |
There was a problem hiding this comment.
Seems like a good candidate for the function (you have a couple "symbols related functions" within this PR
| return Err(Error::<T>::SymbolDoesNotExist.into()); | ||
| } | ||
|
|
||
| let used_symbols = TokenSymbol::<T>::iter_values().collect::<Vec<_>>(); |
There was a problem hiding this comment.
This is the second unbounded iteration here. @gregzaitsev Do we care about weights optimizations here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the subnet owner (and root) to change the subnet symbol if it exists and is not already in use.
During subnet creation, the next available symbol is determined by checking if the symbol for the given subnet ID is available. If it is not, the system iterates through the symbol list to find the next available one. If no symbols are available because the list is exhausted, the default symbol is used until the symbol list is extended.
Additionally, the symbol list is refactored to be static.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.